Extract SARIF upload to separate workflow and improve C++ flags - #11529
Open
garazdawi wants to merge 6 commits into
Open
Extract SARIF upload to separate workflow and improve C++ flags#11529garazdawi wants to merge 6 commits into
garazdawi wants to merge 6 commits into
Conversation
In order to not couple the ossf and zizmor tool status with the status of the main.yaml workflow we break the upload of those sarif files out into their own workflows so that warnings in the github gui disappear.
As per OSSF Compiler Hardening Guide
Contributor
CT Test Results 8 files 183 suites 1h 23m 36s ⏱️ Results for commit e96c674. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts the sarif upload of the ossf compiler flags scanner and Zizmor into their own workflows so that when looking at the status of the checks in the code scanning tools it does not carry the status of the entire main.yaml workflow.
The PR also adds CXXFLAGS to
system_info(compile_info)so that we can check for flags that are solely in CXXFLAGS. It then also adds-fzero-call-used-regs=usedto CFLAGS and-D_LIBCPP_HARDENING_MODEto CXXFLAGS.